Skip to content

Conversation

@cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal requested a review from timroes November 1, 2017 23:48
@cjcenizal
Copy link
Contributor Author

@timroes I made some additional changes to this component, e.g. incorporating KeyboardAccessible.

@snide
Copy link
Contributor

snide commented Nov 2, 2017

@cjcenizal What's the best way to theme this? Looks like we're just using the defaults coming out of the repo. Should i just plop something on top?

@cjcenizal
Copy link
Contributor Author

@snide Yeah I think we could just create a file called ace_elastic_theme.scss inside of this module and define styles like: https://github.com/ajaxorg/ace/blob/master/lib/ace/theme/textmate.css. That will probably do the trick as a basic solution. I think we could go further and register the theme
(e.g. https://github.com/ajaxorg/ace/blob/master/lib/ace/theme/textmate.js) but that might not be necessary.

@cjcenizal cjcenizal merged commit aacb88d into elastic:master Nov 2, 2017
@cjcenizal cjcenizal deleted the feature/code-editor branch November 2, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants