Bug fix: FeatureHasher’s transform expects a list of list of strings #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I see that a similar PR has already been proposed… feel free to close mine. |
k0T0z
added a commit
to scorpionantimalware/ember
that referenced
this pull request
Nov 24, 2023
…lastic/ember#108, elastic/ember#99, and elastic/ember#93 Signed-off-by: Saif Kandil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent version of scikit-learn added a check to the input data of the function "transform" in FeatureHasher. The details are in this pull request: scikit-learn/scikit-learn#25094.
This check fails when transform in invoked by ember on this line (in ember/features.py, line 192):
entry_name_hashed = FeatureHasher(50, input_type="string").transform([raw_obj['entry']]).toarray()[0]because
[raw_obj['entry']]is a list of strings, not a list of list of strings.This pull request changes this call to transform by wrapping everything in a list.
I am not sure of the soundness of my fix, so I encourage the reviewer to have a deeper look.