Remove action allowlist on the server side#96936
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Jun 21, 2023
Merged
Remove action allowlist on the server side#96936elasticsearchmachine merged 3 commits intoelastic:mainfrom
elasticsearchmachine merged 3 commits intoelastic:mainfrom
Conversation
With the new cross-cluster API keys (elastic#95714), RCS 2.0 is more tightly controlled. This removes the need for the action allowlist on the server side because cross-cluster API keys (1) require manage_security to create and (2) are specifized to give out only cross-cluster operation related privileges. Hence this PR removes the allowlist.
ywangd
added
>non-issue
:Security/Authorization
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
Jun 20, 2023
Contributor
n1v0lg
left a comment
n1v0lg
left a comment
There was a problem hiding this comment.
LGTM. I'm on board with this as it makes the code easier to maintain. I agree with your analysis in the Jira of the security impact (i.e., lack therefore) of this change.
...ity/src/test/java/org/elasticsearch/xpack/security/transport/ServerTransportFilterTests.java
Outdated
Show resolved
Hide resolved
...ity/src/test/java/org/elasticsearch/xpack/security/transport/ServerTransportFilterTests.java
Outdated
Show resolved
Hide resolved
| @@ -48,7 +48,6 @@ | |||
| import static org.elasticsearch.xpack.core.security.support.Exceptions.authenticationError; | |||
Contributor
There was a problem hiding this comment.
We gotta fix up testInboundDestructiveOperations as well.
Member
Author
There was a problem hiding this comment.
Good catch 👍 I totally missed it
ywangd
added
the
auto-merge-without-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new cross-cluster API keys (#95714), RCS 2.0 is more tightly controlled. This removes the need for the action allowlist on the server side because cross-cluster API keys (1) require manage_security to create and (2) are specifized to give out only cross-cluster operation related privileges. Hence this PR removes the allowlist.