Disallow derived cross-cluster API keys#96401
Merged
elasticsearchmachine merged 6 commits intoelastic:mainfrom May 31, 2023
Merged
Disallow derived cross-cluster API keys#96401elasticsearchmachine merged 6 commits intoelastic:mainfrom
elasticsearchmachine merged 6 commits intoelastic:mainfrom
Conversation
This PR actively blocks creating cross-cluster API keys with another API key to avoid the issue of derived API key ownership.
ywangd
added
>non-issue
:Security/Security
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
May 30, 2023
| assertThat(e.getResponse().getStatusLine().getStatusCode(), equalTo(400)); | ||
| assertThat( | ||
| e.getMessage(), | ||
| containsString("authentication via API key not supported: only non-API key users can create a cross-cluster API key") |
Contributor
There was a problem hiding this comment.
Nit: only non-API key users sounds confusing in that it feels like it can mean "not users of API keys" -- would go with "An API key cannot be used to create a cross-cluster API key." or similar.
Member
Author
There was a problem hiding this comment.
Updated as suggested. Thanks!
ywangd
added
the
auto-merge-without-approval
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-1-fips |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR actively blocks creating cross-cluster API keys with another API key to avoid the issue of derived API key ownership.
Relates: #95714