Skip to content

Increment StackTemplateRegistry#REGISTRY_VERSION#95715

Merged
eyalkoren merged 2 commits intomainfrom
StackTemplateRegistry-version-increment
May 3, 2023
Merged

Increment StackTemplateRegistry#REGISTRY_VERSION#95715
eyalkoren merged 2 commits intomainfrom
StackTemplateRegistry-version-increment

Conversation

@eyalkoren
Copy link
Contributor

Required due to changes made in stack templates in #95481 and #95329

Required due to changes made in stack templates in #95481 and #95329
@eyalkoren eyalkoren requested a review from dakrone May 2, 2023 03:55
@elasticsearchmachine elasticsearchmachine added v8.9.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 2, 2023
@elasticsearchmachine
Copy link
Collaborator

@eyalkoren please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@pxsalehi pxsalehi added :StorageEngine/Data streams Data streams and their lifecycles and removed needs:triage Requires assignment of a team area label labels May 2, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label May 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eyalkoren
Copy link
Contributor Author

eyalkoren commented May 3, 2023

What is required, other than passing tests, for merging this one?
I am not sure which label to choose that will not trigger an automatic changelog entry creation. Can we merge without a label?

@dakrone
Copy link
Member

dakrone commented May 3, 2023

I am not sure which label to choose that will not trigger an automatic changelog entry creation. Can we merge without a label?

Normally we would use >non-issue for this, I'll add that label.

@eyalkoren eyalkoren merged commit 842b119 into main May 3, 2023
@eyalkoren eyalkoren deleted the StackTemplateRegistry-version-increment branch May 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments