-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[Logs+] Add support for logs@custom component template
#95481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felixbarny
merged 8 commits into
elastic:main
from
eyalkoren:custom-logs-mapping-template
Apr 27, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a203206
Add support for logs@custom component template
eyalkoren 0abceb9
Update docs/changelog/95481.yaml
eyalkoren 2801357
Update 95481.yaml
eyalkoren c6ee343
Relying only on required templates when deleting
eyalkoren 7455ba6
Merge remote-tracking branch 'eyalkoren/custom-logs-mapping-template'…
eyalkoren f2159b0
Not failing template creation due to missing non-required templates
eyalkoren 567d46d
Fix formatting
eyalkoren 4d0670e
Merge remote-tracking branch 'upstream/main' into custom-logs-mapping…
eyalkoren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| pr: 95481 | ||
| summary: "Add support for `logs@custom` component template for `logs-*-* data streams" | ||
| area: Data streams | ||
| type: enhancement | ||
| issues: | ||
| - 95469 | ||
37 changes: 37 additions & 0 deletions
37
...ms/src/yamlRestTest/resources/rest-api-spec/test/data_stream/210_logs_custom_mappings.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| "Basic logs@custom component template functionality test": | ||
| - do: | ||
| cluster.put_component_template: | ||
| name: logs@custom | ||
| body: | ||
| template: | ||
| settings: | ||
| index: | ||
| query: | ||
| default_field: [ "custom-message" ] | ||
| mappings: | ||
| properties: | ||
| numeric_field: | ||
| type: integer | ||
|
|
||
| - do: | ||
| indices.create_data_stream: | ||
| name: logs-generic-default | ||
| - is_true: acknowledged | ||
|
|
||
| - do: | ||
| indices.get_data_stream: | ||
| name: logs-generic-default | ||
| - set: { data_streams.0.indices.0.index_name: idx0name } | ||
|
|
||
| - do: | ||
| indices.get_settings: | ||
| index: $idx0name | ||
| # verify that the custom settings.index.query.default_field overrides the default query field - "message" | ||
| - match: { .$idx0name.settings.index.query.default_field: ["custom-message"] } | ||
|
|
||
| - do: | ||
| indices.get_mapping: | ||
| index: $idx0name | ||
| # verify that the new field from the custom component template is applied | ||
| - match: { .$idx0name.mappings.properties.numeric_field.type: "integer" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.