Skip to content

Exclude unsearchable shards in search API#93615

Merged
dnhatn merged 5 commits intoelastic:mainfrom
dnhatn:search_roles
Feb 10, 2023
Merged

Exclude unsearchable shards in search API#93615
dnhatn merged 5 commits intoelastic:mainfrom
dnhatn:search_roles

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 9, 2023

Relates #93010

@dnhatn dnhatn added >enhancement :Search/Search Search-related issues that do not fall into other categories v8.8.0 labels Feb 9, 2023
@dnhatn dnhatn requested a review from DaveCTurner February 9, 2023 04:12
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Feb 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn requested a review from tlrx February 9, 2023 15:06
@dnhatn dnhatn changed the title Exclude unsearchable shards in search/get API Exclude unsearchable shards in search API Feb 9, 2023
@dnhatn
Copy link
Member Author

dnhatn commented Feb 9, 2023

I talked to @Tim-Brooks on this PR. We agreed to proceed with his PR (#93612) as we are not ready to use only searchable shards for the GET API yet. I have removed the changes for the GET API from this.

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Feb 10, 2023

Thanks Tim!

@dnhatn dnhatn merged commit f38ecca into elastic:main Feb 10, 2023
@dnhatn dnhatn deleted the search_roles branch February 10, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants