Make password long enough for FIPS mode #93450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>test
elasticsearchmachine
added
v8.7.0
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
I haven't had time to check if other tests in that suite have the same issue or not since test triage is pretty busy today. @grcevski would be able to run the suite with |
grcevski
approved these changes
Feb 2, 2023
Contributor
grcevski
left a comment
grcevski
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this!
Contributor
|
I confirmed, it's the only one that still fails in the whole Test file. |
Contributor
Author
|
Ideal, thanks @grcevski! |
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 2, 2023
In FIPS mode, passwords require a minimal length. This PR adjusts a test to adhere to this. Fixes: elastic#93449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FIPS mode, passwords require a minimal length. This PR adjusts a test to adhere to this.
Fixes: #93449