Do not refresh all indices in TransportBulkAction #93417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>bug
:Distributed Indexing/CRUD
Collaborator
|
Hi @tlrx, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
Thanks David. Actually I think the refresh should also use indices options that expands to lenient open and hidden indices (otherwise hidden indices are not refreshed). |
DaveCTurner
approved these changes
Feb 1, 2023
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LBTM (good -> better 😁 )
Do we have test coverage for this? We should add some if not.
Member
Author
|
Thanks David. I'll add a test in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we know which indices were involved in the Bulk request we can refresh only those instead of all indices.
Relates #93160