Avoiding race conditions in GeoIpDownloaderIT #93363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GeoIpDownloader has some race conditions (documented in #92888) that were made more likely to occur by #92335 since it's now more common to enable and disable the GeoIpDownloader in tests. This PR works around the race condition by adding a geoip processor that would be unnecessary without the race condition.
I don't have a great way to reproduce this. I ran it ~700 times with and without my fix using something like:
Without my fix I saw it fail twice. With my fix I have not seen any failures. The failure is: