Skip to content

Conversation

@mjrlgue
Copy link
Contributor

@mjrlgue mjrlgue commented Jan 30, 2023

It took me a considerable time to figure out the code for a token-based authentication, and I said why not add it to the documentation.

@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.6.2 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 30, 2023
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @mjrlgue . Thanks for sharing!

I've left some minor suggestions. Also, this PR should target the main branch so this change will also be in future versions of the documentation. Do you need a hand rebasing this PR?

@abdonpijpelink abdonpijpelink added >docs General docs changes :Data Management/Watcher and removed needs:triage Requires assignment of a team area label labels Jan 30, 2023
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Jan 30, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@abdonpijpelink abdonpijpelink self-assigned this Jan 30, 2023
@abdonpijpelink abdonpijpelink marked this pull request as draft January 31, 2023 08:51
mjrlgue and others added 3 commits January 31, 2023 09:52
It took me a considerable time to figure out the syntax for a token-based authentication, and I said why not add it to the documentation
@cla-checker-service
Copy link

cla-checker-service bot commented Jan 31, 2023

💚 CLA has been signed

@abdonpijpelink abdonpijpelink changed the base branch from 8.6 to main January 31, 2023 08:57
@abdonpijpelink abdonpijpelink marked this pull request as ready for review January 31, 2023 08:58
@abdonpijpelink
Copy link
Contributor

@elasticmachine test this please

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.6

abdonpijpelink added a commit to abdonpijpelink/elasticsearch that referenced this pull request Jan 31, 2023
* Add a section about token-based authentication

It took me a considerable time to figure out the syntax for a token-based authentication, and I said why not add it to the documentation

* Update x-pack/docs/en/watcher/input/http.asciidoc

* Update x-pack/docs/en/watcher/input/http.asciidoc

---------

Co-authored-by: Abdon Pijpelink <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 31, 2023
* Add a section about token-based authentication

It took me a considerable time to figure out the syntax for a token-based authentication, and I said why not add it to the documentation

* Update x-pack/docs/en/watcher/input/http.asciidoc

* Update x-pack/docs/en/watcher/input/http.asciidoc

---------

Co-authored-by: Marwane Chahoud <[email protected]>
@mjrlgue mjrlgue deleted the patch-2 branch January 31, 2023 13:43
mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Jan 31, 2023
* Add a section about token-based authentication

It took me a considerable time to figure out the syntax for a token-based authentication, and I said why not add it to the documentation

* Update x-pack/docs/en/watcher/input/http.asciidoc

* Update x-pack/docs/en/watcher/input/http.asciidoc

---------

Co-authored-by: Abdon Pijpelink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Watcher >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.6.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants