Extract some methods from IngestService's innerExecute method #93213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #81244
This PR hollows out the body of
innerExecuteby extracting some methods from it (and updating it to call those methods).There's no real change in behavior here, I tried to keep this a 1-to-1 in terms of the before and after. The closest thing there is to a change is that the
getDynamicTemplates/setDynamicTemplatesblock is executed slightly earlier than before, since it moves into the body ofupdateIndexRequestMetadata, but I don't think that affects anything else.This PR is a prelude to a follow up PR which will rework these new functions to be called outside of
innerExecute, but I'm hoping to keep the overall effort more reviewable by keeping this PR to just the "pull out some new methods" part of the work.