Skip to content

Fix test examples for nori-analyzer #92336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javanna merged 7 commits into from
Jan 11, 2023
Merged

Fix test examples for nori-analyzer #92336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f43d083
[DOCS] Fix typo in analysis-nori.asciidoc
jso4342 Dec 13, 2022
ce113e4
[DOCS] Fix typo in userdict_ko
jso4342 Dec 13, 2022
b574c55
Fix typo in noriAnalysisTest
jso4342 Dec 13, 2022
4abe5e2
Fix typo in user_dict.txt
jso4342 Dec 13, 2022
690a1a6
fix: Fix typo for NoriAnalysis and solve build error
jso4342 Dec 22, 2022
52bb4a6
fix: Fix typo
jso4342 Dec 22, 2022
14a6652
Merge branch 'main' into nori-fix-typo
elasticmachine Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/plugins/analysis-nori.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ dictionary to `$ES_HOME/config/userdict_ko.txt`:
[source,txt]
-----------------------
c++ <1>
C샤프
C쁠쁠
세종
세종시 세종 시 <2>
-----------------------
Expand Down Expand Up @@ -176,7 +176,7 @@ PUT nori_sample
"nori_user_dict": {
"type": "nori_tokenizer",
"decompound_mode": "mixed",
"user_dictionary_rules": ["c++", "C샤프", "세종", "세종시 세종 시"]
"user_dictionary_rules": ["c++", "C쁠쁠", "세종", "세종시 세종 시"]
}
},
"analyzer": {
Expand Down
4 changes: 2 additions & 2 deletions docs/src/test/cluster/config/userdict_ko.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Additional nouns
c++
C샤프
C쁠쁠
세종
세종시 세종 시
세종시 세종 시
4 changes: 2 additions & 2 deletions ...analysis-nori/src/test/java/org/elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public void testNoriAnalyzer() throws Exception {
public void testNoriAnalyzerUserDict() throws Exception {
Settings settings = Settings.builder()
.put("index.analysis.analyzer.my_analyzer.type", "nori")
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C샤프", "세종", "세종시 세종 시")
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C쁠쁠", "세종", "세종시 세종 시")
.build();
TestAnalysis analysis = createTestAnalysis(settings);
Analyzer analyzer = analysis.indexAnalyzers.get("my_analyzer");
Expand Down Expand Up @@ -108,7 +108,7 @@ public void testNoriAnalyzerInvalidUserDictOption() throws Exception {
Settings settings = Settings.builder()
.put("index.analysis.analyzer.my_analyzer.type", "nori")
.put("index.analysis.analyzer.my_analyzer.user_dictionary", "user_dict.txt")
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C샤프", "세종", "세종시 세종 시")
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C쁠쁠", "세종", "세종시 세종 시")
.build();
IllegalArgumentException exc = expectThrows(IllegalArgumentException.class, () -> createTestAnalysis(settings));
assertThat(
Expand Down
4 changes: 2 additions & 2 deletions ...ins/analysis-nori/src/test/resources/org/elasticsearch/plugin/analysis/nori/user_dict.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Additional nouns
c++
C샤프
C쁠쁠
세종
세종시 세종 시
세종시 세종 시