Execute async cleanup tasks in CoordinatorTests #91794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing the `JoinValidationService` will enqueue a cache-cleaning task which must be executed to release any pages held by the cache. This commit also introduces a deterministic leak detector to replace the one based on garbage collection, because in these tests we know exactly the expected lifecycle of all allocated pages. Closes elastic#91599 Closes elastic#91379 Closes elastic#90576
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
kingherc
approved these changes
Nov 22, 2022
Contributor
kingherc
left a comment
kingherc
left a comment
There was a problem hiding this comment.
LGTM! Just one comment if you think more tracing might help in the future.
| @Override | ||
| public Recycler.V<byte[]> bytePage(boolean clear) { | ||
| final var page = super.bytePage(clear); | ||
| openPages += 1; |
Contributor
There was a problem hiding this comment.
It would be nice if log is e.g. TRACE to also capture the thread stack of the pages. That way, if the assertion that there is no page remaining fails, we may be able to inspect which thread stacks created them. I believe this should be cheap for the majority of the tests (since I guess they do not run in TRACE mode) and when a test fails we may easily re-run it with TRACE to figure out leaks.
This is optional if you consider this would be beneficial.
Contributor
Author
There was a problem hiding this comment.
I think I'd prefer not to do this here, it would mean we can't just use a counter to check for leaks (or we'd have two whole different implementations depending on the log level). I'd rather just add such tracing code as and when it's needed.
Contributor
Author
|
I'm running some iterations of the |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 22, 2022
Closing the `JoinValidationService` will enqueue a cache-cleaning task which must be executed to release any pages held by the cache. This commit also introduces a deterministic leak detector to replace the one based on garbage collection, because in these tests we know exactly the expected lifecycle of all allocated pages. Closes elastic#91599 Closes elastic#91379 Closes elastic#90576
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 22, 2022
Closing the `JoinValidationService` will enqueue a cache-cleaning task which must be executed to release any pages held by the cache. This commit also introduces a deterministic leak detector to replace the one based on garbage collection, because in these tests we know exactly the expected lifecycle of all allocated pages. Closes elastic#91599 Closes elastic#91379 Closes elastic#90576
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2022
Closing the `JoinValidationService` will enqueue a cache-cleaning task which must be executed to release any pages held by the cache. This commit also introduces a deterministic leak detector to replace the one based on garbage collection, because in these tests we know exactly the expected lifecycle of all allocated pages. Closes #91599 Closes #91379 Closes #90576
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2022
Closing the `JoinValidationService` will enqueue a cache-cleaning task which must be executed to release any pages held by the cache. This commit also introduces a deterministic leak detector to replace the one based on garbage collection, because in these tests we know exactly the expected lifecycle of all allocated pages. Closes #91599 Closes #91379 Closes #90576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the
JoinValidationServicewill enqueue a cache-cleaning task which must be executed to release any pages held by the cache.This commit also introduces a deterministic leak detector to replace the one based on garbage collection, because in these tests we know exactly the expected lifecycle of all allocated pages.
Closes #91599
Closes #91379
Closes #90576