-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add profiling plugin #91640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielmitterdorfer
merged 19 commits into
elastic:main
from
danielmitterdorfer:profiler-plugin
Nov 30, 2022
Merged
Add profiling plugin #91640
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
178f6da
Add profiling plugin
danielmitterdorfer 168eb31
Profiling API is a non-operator API
danielmitterdorfer 1f6ac55
More tests
danielmitterdorfer a3989ad
Rename profiler package
danielmitterdorfer cdc8331
Add IT
danielmitterdorfer 6b0ed41
Formatting fixes
danielmitterdorfer 59a239f
More tests
danielmitterdorfer 5c37833
Add flag xpack.profiling.enabled
danielmitterdorfer df47f95
Don't disable transport action
danielmitterdorfer 883cf46
Update docs/changelog/91640.yaml
danielmitterdorfer 907d5a5
Merge remote-tracking branch 'origin/main' into profiler-plugin
danielmitterdorfer f6ae666
Merge remote-tracking branch 'origin/main' into profiler-plugin
danielmitterdorfer c21262b
Address review feedback
danielmitterdorfer 84f1acf
Implement GetProfilingResponseTests as AbstractWireSerializingTestCase
danielmitterdorfer b86f885
Remove obsolete trace context
danielmitterdorfer 62b9fc8
Use applyContentParser for request body parsing
danielmitterdorfer a9caddf
Merge remote-tracking branch 'origin/main' into profiler-plugin
danielmitterdorfer b445b6d
Add cancellation test
danielmitterdorfer 55c158a
Verify task hierarchy is cancelled
danielmitterdorfer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also check that all children tasks are cancelled? My understanding is that we are now checking that the top-level profiling action is cancelled. Ideally, we'd make sure that the children search tasks either don't start before the cancellation, or get cancelled, or complete before the cancellation.
We could check here that there are no tasks with this specific parent task id, on the other hand that would be the case even if we did not set the parent task id properly. Should we instead try and collect those children tasks before the cancellation and double check that they do get cancelled afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely sure though where things get blocked with the script below, maybe always at the first inner search request? ideally it would block at any stage but that sounds like it would complicate this test quite a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I've implemented this now in 55c158a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll merge it then when CI is green. :)