Skip to content

Skip prevoting if single-node discovery #91255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Skip prevoting if single-node discovery #91255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6db3bcc
Skip prevoting if single-node discovery
kingherc Nov 2, 2022
c09b10c
Fix message
kingherc Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/src/main/java/org/elasticsearch/cluster/coordination/Coordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,10 @@ public void run() {
}

if (prevotingRound != null) {
if (singleNodeDiscovery) {
logger.debug("skip prevoting as single-node discovery is enabled and prevoting is already in progress");
return;
}
prevotingRound.close();
}
prevotingRound = preVoteCollector.start(lastAcceptedState, getDiscoveredNodes());
Expand Down
2 changes: 1 addition & 1 deletion ...ork/src/main/java/org/elasticsearch/cluster/coordination/AbstractCoordinatorTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ protected static int defaultInt(Setting<Integer> setting) {
return setting.get(Settings.EMPTY);
}

// Updating the cluster state involves up to 7 delays:
// Updating the cluster state involves up to the following number of delays:
// 1. submit the task to the master service
// 2. state publisher task on master
// 3. master sends out PublishRequests to nodes
Expand Down