Skip to content

[8.5] Ensure cleanups succeed in JoinValidationService (#90601) #91253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2022
Merged

[8.5] Ensure cleanups succeed in JoinValidationService (#90601) #91253

merged 1 commit into from
Nov 2, 2022

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Nov 2, 2022

Backports the following commits to 8.5:

@DaveCTurner
Ensure cleanups succeed in JoinValidationService (elastic#90601)
6dc7f41 
Today we sort of assume that cleanups succeed in the
`JoinValidationService`. A failure in these places might explain the
leaks seen in elastic#90576 and elastic#89712. It's not obvious that anything can fail
here but let's make sure.
@DaveCTurner DaveCTurner added :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Nov 2, 2022
@elasticsearchmachine elasticsearchmachine mentioned this pull request Nov 2, 2022
Merged
@elasticsearchmachine elasticsearchmachine merged commit 6bc5f51 into elastic:8.5 Nov 2, 2022
@DaveCTurner DaveCTurner deleted the backport/8.5/pr-90601 branch November 2, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.5.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaveCTurner @elasticsearchmachine