Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 31, 2022

  1. Moves integration tests from an ESIntegTestCase into a REST test so we can do forwards compatibility tests with it later.
  2. Moves the bucket_sort pipeline agg from server into modules:aggregations so it'll be a little easier to test it.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.6.0 labels Oct 31, 2022
@nik9000 nik9000 requested a review from martijnvg October 31, 2022 21:21
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 31, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

1. Moves integration tests from an `ESIntegTestCase` into a REST test so
   we can do forwards compatibility tests with it later.
2. Moves the `bucket_sort` pipeline agg from `server` into
   `modules:aggregations` so it'll be a little easier to test it.
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I like that this PR replaces an internal java test suite with a yaml test suite.

@nik9000 nik9000 merged commit b981c0c into elastic:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants