Example stable plugin #90805
Merged
Example stable plugin #90805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in elastic#90707 a org.elasticsearch.test.AbstractSerializingTestCase was refactored and AbstractXContentSerializingTestCase should be used instead.
Collaborator
|
Hi @pgomulka, I've created a changelog YAML for you. |
…ample_stable_plugin
| @@ -0,0 +1,34 @@ | |||
| //TODO guide - mention buildscript (in parent) | |||
Contributor
There was a problem hiding this comment.
Note: "buildscript" is a code block in build.gradle. The plugin developer can begin their project by copying and pasting the code block.
Contributor
Author
|
@elasticmachine ok to test |
Contributor
|
@elasticmachine test this please |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
williamrandolph
approved these changes
Oct 26, 2022
Contributor
williamrandolph
left a comment
williamrandolph
left a comment
There was a problem hiding this comment.
This is great work. I've run a successful live demo with it, and will be creating a guide for it soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an example stable-analysis plugin under plugins/examples to show a usage of the new stable analysis api.
It implements AnalyzerFactory, CharFilterFactory, TokenFilterFactory and TokenizerFactory.
it also presents how to write unit tests and yaml rest tests without the dependencies on elasticsearch test framework.
relates #88980