Fix debug mode in MaxRetryAllocationDecider #89973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.
DaveCTurner
added
>bug
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
idegtiarenko
approved these changes
Sep 9, 2022
original-brownbear
approved these changes
Sep 9, 2022
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
Wops sorry about that LGTM
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
deleted the
2022-09-09-MaxRetryAllocationDecider-debug-mode
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 9, 2022
In elastic#62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Sep 9, 2022
In #62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 12, 2022
In #62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.