Remove ImmutableOpenMap from some server tests #89864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
force-pushed
the
immutablemap-server-tests
branch
from
ac49461 to
86aa35d
Compare
thecoop
force-pushed
the
immutablemap-server-tests
branch
from
86aa35d to
b6169c5
Compare
elasticsearchmachine
added
the
needs:triage
Member
Author
|
Part of #86239 |
thecoop
added
Team:Core/Infra
elasticsearchmachine
added
needs:triage
thecoop
added
>refactoring
Team:Core/Infra
elasticsearchmachine
added
needs:triage
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
removed
the
needs:triage
thecoop
added
needs:triage
grcevski
reviewed
Sep 7, 2022
server/src/test/java/org/elasticsearch/cluster/serialization/DiffableTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamMetadataTests.java
Outdated
Show resolved
Hide resolved
grcevski
approved these changes
Sep 7, 2022
Contributor
grcevski
left a comment
grcevski
left a comment
There was a problem hiding this comment.
LGTM! Thanks for iterating on this!
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote ImmutableOpenMap from some classes in server tests