Don't acquire Engine's readLock in segmentsStats #8910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
can we do this on |
|
kk i'll port to 1.3.7 too |
mikemccand
added a commit
that referenced
this pull request
Dec 12, 2014
Today, shard stats are blocked while phase 3 of recovery (replay xlog) is running; this change removes the engine readLock from shard stats so it's not blocked. Closes #8910
mikemccand
added a commit
that referenced
this pull request
Dec 12, 2014
Today, shard stats are blocked while phase 3 of recovery (replay xlog) is running; this change removes the engine readLock from shard stats so it's not blocked. Closes #8910
mikemccand
added a commit
that referenced
this pull request
Dec 12, 2014
Today, shard stats are blocked while phase 3 of recovery (replay xlog) is running; this change removes the engine readLock from shard stats so it's not blocked. Closes #8910
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today, shard stats are blocked while phase 3 of recovery (replay xlog) is running; this change removes the engine readLock from shard stats so it's not blocked. Closes elastic#8910
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today, shard stats are blocked while phase 3 of recovery (replay xlog) is running; this change removes the engine readLock from shard stats so it's not blocked. Closes elastic#8910
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we don't really need the readLock in InternalEngine.segmentsStats?
Related to #8905