Skip to content

Fix incorrect switch cases in AggregationTests #88757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix incorrect switch cases in AggregationTests #88757

merged 1 commit into from
Jul 25, 2022

Conversation

@csoulios
Copy link
Contributor

@csoulios csoulios commented Jul 25, 2022

Fixes aggregation tests that contain switch statements with branches that will never execute. The tests use a between(x, y) switch expression, but there are case values that are outside the randomised range.

Fixes #88745

@csoulios csoulios added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes auto-backport Automatically create backport pull requests when merged v8.4.0 v7.17.6 labels Jul 25, 2022
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 25, 2022

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 25, 2022
iverase
iverase approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csoulios csoulios merged commit beb031d into elastic:main Jul 25, 2022
@csoulios csoulios deleted the invalid-switches-fix branch July 25, 2022 11:13
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 25, 2022

💔 Backport failed

Status Branch Result
❌ 7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 88757

@csoulios csoulios mentioned this pull request Jul 25, 2022
Merged
@csoulios csoulios added backport and removed auto-backport Automatically create backport pull requests when merged backport labels Jul 25, 2022
csoulios added a commit that referenced this pull request Jul 25, 2022
@csoulios
[7.17] Fix incorrect switch cases in AggregationTests (#88767)
8d32f5b 
Backports #88757 to 7.17

- Fixes aggregation tests that contain switch statements with branches that will never execute. The tests use a between(x, y) switch expression, but there are case values that are outside the randomised range.

- Fixes #88745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iverase iverase iverase approved these changes

Assignees

No one assigned

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.17.6 v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aggregation tests have switches with impossible branches

3 participants

@csoulios @elasticsearchmachine @iverase