Skip to content

Conversation

@benwtrent
Copy link
Member

API cancellation was erroneously using the node-name for the parent task id. Task ids are constructed via the node ID, not name.

This fixes that bug.

related to:

@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jul 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 19, 2022
@elasticsearchmachine elasticsearchmachine merged commit 0d7e4c2 into elastic:master Jul 19, 2022
@benwtrent benwtrent deleted the bugfix/ml-cancel-apis branch July 19, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants