Specify proper port range in InternalTestCluster #87885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today nodes started in an `InternalTestCluster` use `transport.port: 0` and `http.port: 0` which selects a port from the ephemeral range. This range is also used by other tests, notably REST tests, and this can lead to collisions and consequent failures when nodes restart. This commit restricts the range of ports using the same algorithm as in `ESTestCase`, avoiding[^1] such collisions. [^1]: technically this isn't quite enough because the ephemeral range on some CI workers overlaps the ranges chosen by `ESTestCase`, but that's a separate issue tracked in elastic#87734 Closes elastic#87448
DaveCTurner
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Jun 21, 2022
DaveCTurner
deleted the
2022-06-21-specify-port-range-in-InternalTestCluster
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 21, 2022
Today nodes started in an `InternalTestCluster` use `transport.port: 0` and `http.port: 0` which selects a port from the ephemeral range. This range is also used by other tests, notably REST tests, and this can lead to collisions and consequent failures when nodes restart. This commit restricts the range of ports using the same algorithm as in `ESTestCase`, avoiding[^1] such collisions. [^1]: technically this isn't quite enough because the ephemeral range on some CI workers overlaps the ranges chosen by `ESTestCase`, but that's a separate issue tracked in elastic#87734 Closes elastic#87448
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 21, 2022
Today nodes started in an `InternalTestCluster` use `transport.port: 0` and `http.port: 0` which selects a port from the ephemeral range. This range is also used by other tests, notably REST tests, and this can lead to collisions and consequent failures when nodes restart. This commit restricts the range of ports using the same algorithm as in `ESTestCase`, avoiding[^1] such collisions. [^1]: technically this isn't quite enough because the ephemeral range on some CI workers overlaps the ranges chosen by `ESTestCase`, but that's a separate issue tracked in elastic#87734 Closes elastic#87448
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 21, 2022
Today nodes started in an `InternalTestCluster` use `transport.port: 0` and `http.port: 0` which selects a port from the ephemeral range. This range is also used by other tests, notably REST tests, and this can lead to collisions and consequent failures when nodes restart. This commit restricts the range of ports using the same algorithm as in `ESTestCase`, avoiding[^1] such collisions. [^1]: technically this isn't quite enough because the ephemeral range on some CI workers overlaps the ranges chosen by `ESTestCase`, but that's a separate issue tracked in #87734 Closes #87448
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 21, 2022
Today nodes started in an `InternalTestCluster` use `transport.port: 0` and `http.port: 0` which selects a port from the ephemeral range. This range is also used by other tests, notably REST tests, and this can lead to collisions and consequent failures when nodes restart. This commit restricts the range of ports using the same algorithm as in `ESTestCase`, avoiding[^1] such collisions. [^1]: technically this isn't quite enough because the ephemeral range on some CI workers overlaps the ranges chosen by `ESTestCase`, but that's a separate issue tracked in #87734 Closes #87448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today nodes started in an
InternalTestClusterusetransport.port: 0and
http.port: 0which selects a port from the ephemeral range. Thisrange is also used by other tests, notably REST tests, and this can lead
to collisions and consequent failures when nodes restart.
This commit restricts the range of ports using the same algorithm as in
ESTestCase, avoiding1 such collisions.Closes #87448
Footnotes
technically this isn't quite enough because the ephemeral range on
some CI workers overlaps the ranges chosen by
ESTestCase, but that's aseparate issue tracked in [CI] Real-cluster tests pick ports that clash with ESTestCase port ranges #87734 ↩