Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Apr 25, 2022

The top hits aggregator uses hppc for keeping track of leaf bucket
collectors. This commit converts it to use HashMap.

relates #84735

The top hits aggregator uses hppc for keeping track of leaf bucket
collectors. This commit converts it to use HashMap.

relates elastic#84735
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 25, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@rjernst rjernst mentioned this pull request Apr 25, 2022
43 tasks
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use LongObjectPagedHashMap here instead? It's known not to allocate. I know top_hits isn't the fastest thing, but we may as well use the tools we build for aggs in aggs.

@rjernst
Copy link
Member Author

rjernst commented Apr 26, 2022

Ok, switched to LongObjectPagedHashMap

@rjernst
Copy link
Member Author

rjernst commented Apr 27, 2022

@nik9000 CI looks happy now, any other concerns?

@rjernst rjernst merged commit 21c8e97 into elastic:master Apr 27, 2022
@rjernst rjernst deleted the hppc/tophits branch April 27, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants