Skip to content

Conversation

grcevski
Copy link
Contributor

This PR removes all references to the now removed option of bootstrap.system_call_filter.

Closes #84862

@grcevski grcevski added >bug >docs General docs changes :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.0.2 v8.3.0 v8.2.1 v8.1.4 labels Apr 18, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Apr 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we can remove this currently in master, since it would be a breaking change? That is, removing the actual setting. We could still make the docs change.

@grcevski
Copy link
Contributor Author

I think the setting was removed in 8.0 (#72848) and its removal is listed in the breaking changes. This just removes some outstanding docs + references to now removed setting. The actual setting static I removed was flagged as unused by IntelliJ, nothing depends on it.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, LGTM then!

@grcevski grcevski merged commit 88600d1 into elastic:master Apr 18, 2022
@grcevski grcevski deleted the docs/system_call_filter branch April 18, 2022 23:33
grcevski added a commit to grcevski/elasticsearch that referenced this pull request Apr 18, 2022
grcevski added a commit to grcevski/elasticsearch that referenced this pull request Apr 18, 2022
grcevski added a commit to grcevski/elasticsearch that referenced this pull request Apr 18, 2022
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
8.2
8.1

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Apr 21, 2022
* master: (104 commits)
  fix: ordering terms aggregation on top metrics null values (elastic#85774)
  Fix up whitespace error introduced in elastic#85948
  More docs re. removing cluster.initial_master_nodes (elastic#85948)
  [Test] Remove API key methods from HLRC (elastic#85802)
  Remove references to bootstrap.system_call_filter (elastic#85964)
  Move docker cgroup override to SystemJvmOptions (elastic#85960)
  Add connection accounting tests (elastic#85966)
  Remove MacOS from platform support testing matrix
  Remove custom KnnVectorFieldExistsQuery (elastic#85945)
  Relax data path deprecations from critical to warn (elastic#85952)
  Remove hppc from some "common" classes (elastic#85957)
  Move docker env var settings handling out of bash (elastic#85913)
  Remove hppc from task manager (elastic#85889)
  [ML] rename trained model allocations to assignments (elastic#85503)
  Remove hppc from multi*shard request and responses (elastic#85888)
  Consolidating logging initialization in cli launcher (elastic#85920)
  Convert license tools to use unified cli entrypoint (elastic#85919)
  Add noop detection to node shutdown actions (elastic#85914)
  Adjust SQL expended test output
  TSDB: Add timestamp provider to AggregationExecutionContext (elastic#85850)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/search/aggregations/AggregationExecutionContext.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.0.2 v8.1.4 v8.2.1 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The docs still reference bootstrap.system_call_filter

4 participants