Only use InitialMasterNodes during bootstrap #85929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋🏼 [This doc](https://www.elastic.co/guide/en/elasticsearch/reference/8.1/modules-discovery-bootstrap-cluster.html) currently says ... (referring to `cluster.initial_master_nodes`). > After the cluster has formed, this setting is no longer required. This should instead push users that this setting ONLY makes sense during bootstrap and should be removed after.
|
Pinging @elastic/es-docs (Team:Docs) |
|
@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
elasticsearchmachine
added
the
external-contributor
DaveCTurner
requested changes
Apr 16, 2022
| When you start a master-eligible node, you can provide this setting on the | ||
| command line or in the `elasticsearch.yml` file. After the cluster has formed, | ||
| this setting is no longer required. It should not be set for master-ineligible | ||
| this setting should no longer be used. It should not be set for master-ineligible |
There was a problem hiding this comment.
I think that's still weaker than it could be. How about making it a command to the user, like this?
Suggested change
| this setting should no longer be used. It should not be set for master-ineligible | |
| remove this setting from the configuration. It should not be set for master-ineligible |
|
Closing in favor of #85948. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋🏼 This doc currently says ... (referring to
cluster.initial_master_nodes).This should instead push users that this setting ONLY makes sense during bootstrap and should be removed after.