test: date_histogram with time zone on date_nanos field #85149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-campagna
changed the title
salvatore-campagna
added
>non-issue
>test
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Member
|
This test can just land in the existing |
| "date_histogram on date_nanos without timezone fixed interval": | ||
| - skip: | ||
| version: " - 8.1.99" | ||
| reason: bug fixed in 8.2.0 |
Member
There was a problem hiding this comment.
The linked issue lists #52016 as resolving this, which landed in 7.6.1. Let's confirm it works there or at least 7.7.0 and update the skip version appropriately. As noted in your other PR, I'm in favor of backporting these tests to 7.17.
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Mar 30, 2022
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
date_histogramtest ondate_nanosfield.The test runs fine without any fix.
Issue: #39107