Skip to content

Remove hppc from dfs search #84688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

Remove hppc from dfs search #84688

merged 1 commit into from
Mar 7, 2022

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Mar 5, 2022

This commit removes the HppcMaps class and converts the few existing
uses, in DFS code, to use Map.

@rjernst
Remove hppc from dfs search
651ddb4 
This commit removes the HppcMaps class and converts the few existing
uses, in DFS code, to use Map.
@rjernst rjernst added the WIP label Mar 5, 2022
@rjernst rjernst added the :Core/Infra/Core Core issues without another label label Mar 7, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Mar 7, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst added >refactoring and removed WIP Team:Core/Infra Meta label for core/infra team labels Mar 7, 2022
@rjernst rjernst requested a review from dakrone March 7, 2022 20:25
@rjernst
Copy link
Member Author

rjernst commented Mar 7, 2022

@dakrone Thanks to @grcevski, we have done a couple rally runs and this change looks like there is no difference (just noise) with the master branch.

dakrone
dakrone approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit df5dbd5 into elastic:master Mar 7, 2022
@rjernst rjernst deleted the hppc/dfs branch March 7, 2022 22:01
@rjernst rjernst mentioned this pull request Mar 7, 2022
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >refactoring v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rjernst @elasticmachine @dakrone @elasticsearchmachine