Skip to content

Remove LegacyCTRAListener from open-indices batching #83807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Remove LegacyCTRAListener from open-indices batching #83807

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f5ce77
Fix the changelog for my previous PR
joegallo Feb 10, 2022
eaa6f87
Simplest possible ActionListener
joegallo Feb 10, 2022
9340e09
A bit more ceremony
joegallo Feb 10, 2022
b157653
Simpler is fine, with a better comment
joegallo Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/changelog/83760.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pr: 83760
summary: Batch open-indices
summary: Batch open-indices cluster state updates
area: Indices APIs
type: enhancement
issues: []
19 changes: 18 additions & 1 deletion server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexStateService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,17 @@ public ClusterTasksResult<OpenIndicesTask> execute(ClusterState currentState, Li
state = allocationService.reroute(state, "indices opened");

for (OpenIndicesTask task : tasks) {
builder.success(task, new LegacyClusterTaskResultActionListener(task, currentState));
builder.success(task, new ActionListener<>() {
@Override
public void onResponse(ClusterState clusterState) {
task.onPublicationComplete();
}

@Override
public void onFailure(Exception e) {
task.onFailure(e);
}
});
}
} catch (Exception e) {
for (OpenIndicesTask task : tasks) {
Expand Down Expand Up @@ -1191,5 +1201,12 @@ public void onAckTimeout() {
public TimeValue ackTimeout() {
return request.ackTimeout();
}

@Override
public void clusterStateProcessed(ClusterState oldState, ClusterState newState) {
assert false : "not called";
}

protected void onPublicationComplete() {}
}
}