Optimize calculating the presence of a quorum #83638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to create new `HashSet` and remove elements from it to get an intersection. We only care about the amount of notes that have voted.
arteam
added
>non-issue
:Distributed Coordination/Cluster Coordination
arteam
force-pushed
the
optimize-has-quorum
branch
2 times, most recently
from
4a692a4 to
155a1f2
Compare
|
@elasticmachine run elasticsearch-ci/part-1 |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Feb 8, 2022
arteam
force-pushed
the
optimize-has-quorum
branch
from
35ceea4 to
015018d
Compare
arteam
added
auto-backport
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 8, 2022
We don't need to create new `HashSet` and remove elements from it to get an intersection. We only care about the amount of notes that have voted.
💚 Backport successful
|
arteam
added a commit
that referenced
this pull request
Feb 8, 2022
arteam
added a commit
that referenced
this pull request
Feb 8, 2022
arteam
added a commit
that referenced
this pull request
Feb 8, 2022
|
This one should also not have been merged to 8.1 since it's not a bugfix. Please would you revert the backport? |
|
Oh ha I see you just did in 613538e. Laggy UI... |
|
Yes, I've realized that, already reverted the PR 👍 |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 9, 2022
* upstream/master: (166 commits) Bind host all instead of just _site_ when needed (elastic#83145) [DOCS] Fix min/max agg snippets for histograms (elastic#83695) [DOCS] Add deprecation notice for system indices (elastic#83688) Cache ILM policy name on IndexMetadata (elastic#83603) [DOCS] Fix 8.0 breaking changes sort order (elastic#83685) [ML] fix random sampling background query consistency (elastic#83676) Move internal APIs into their own namespace '_internal' Runtime fields core-with-mapped tests support tsdb (elastic#83577) Optimize calculating the presence of a quorum (elastic#83638) Use switch expressions in EnableAllocationDecider and NodeShutdownAllocationDecider (elastic#83641) Note libffi error message in tmpdir docs (elastic#83662) Fix TransportDesiredNodesActionsIT batch tests (elastic#83659) [DOCS] Remove unused upgrade doc files (elastic#83617) [ML] Wait for model process to stop in stop deployment (elastic#83644) [ML] Fix submit after shutdown in process worker service (elastic#83645) Remove req/resp classes associated with HLRC (elastic#83599) Introduce index.version.compatibility setting (elastic#83264) Rename InternalTestCluster#getMasterNodeInstance (elastic#83407) Mute TimeSeriesIndexSearcherTests testCollectInOrderAcrossSegments (elastic#83648) Add rollover add max_primary_shard_docs condition (elastic#80981) ... # Conflicts: # x-pack/plugin/rollup/build.gradle # x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to create new
HashSetand remove elements from just to get an intersection set.We only care about the amount of notes that have voted.