Make DiscoveryNodes behave like a collection #83453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend from `AbstractCollection`. Advantages: * Optimized version of `spliterator` based on the size implemented in `AbstractCollection` by default * Exposed `stream` method, so consumers don't need to call `StreamSupport.stream(discoveryNodes.spliterator(), false)`
arteam
added
>non-issue
:Distributed Indexing/Distributed
|
@elasticmachine update branch |
|
@elasticmachine update branch |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
reviewed
Feb 4, 2022
server/src/main/java/org/elasticsearch/cluster/node/DiscoveryNodes.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
1 similar comment
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
arteam
added
auto-backport
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 4, 2022
Backports elastic#83453 to 8.1 ``` Extend from `AbstractCollection`. Advantages: * Optimized version of `spliterator` based on the size implemented in `AbstractCollection` by default * Exposed `stream` method, so consumers don't need to call `StreamSupport.stream(discoveryNodes.spliterator(), false)` ```
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 4, 2022
Extend it from `AbstractCollection` instead of `Iterable` analogous to elastic#83453
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 4, 2022
Since DiscoverNodes now extends `AbstractCollection` we don't need a method exposing DiscoveryNodes as a `Collection` and we can call `stream` directly on `DiscoveryNodes` See elastic#83453
arteam
added a commit
that referenced
this pull request
Feb 4, 2022
Backports #83453 to 8.1 ``` Extend from `AbstractCollection`. Advantages: * Optimized version of `spliterator` based on the size implemented in `AbstractCollection` by default * Exposed `stream` method, so consumers don't need to call `StreamSupport.stream(discoveryNodes.spliterator(), false)` ```
arteam
added a commit
that referenced
this pull request
Feb 7, 2022
Extend it from `AbstractCollection` instead of `Iterable` analogous to #83453
arteam
added a commit
that referenced
this pull request
Feb 7, 2022
Since DiscoverNodes now extends `AbstractCollection` we don't need a method exposing DiscoveryNodes as a `Collection` and we can call `stream` directly on `DiscoveryNodes` See #83453
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 7, 2022
Extend it from `AbstractCollection` instead of `Iterable` analogous to elastic#83453
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 7, 2022
Since DiscoverNodes now extends `AbstractCollection` we don't need a method exposing DiscoveryNodes as a `Collection` and we can call `stream` directly on `DiscoveryNodes` See elastic#83453
arteam
added a commit
that referenced
this pull request
Feb 7, 2022
arteam
added a commit
that referenced
this pull request
Feb 7, 2022
arteam
added a commit
that referenced
this pull request
Feb 14, 2022
arteam
added a commit
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend from
AbstractCollection. Advantages:spliteratorbased on the collection size which is implemented inAbstractCollectionby default.streammethod, so consumers don't need to callStreamSupport.stream(discoveryNodes.spliterator(), false)