Skip to content

[DOCS] Fix copy/paste error in min agg docs #83384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DOCS] Fix copy/paste error in min agg docs #83384

wants to merge 1 commit into from

Conversation

@LucoEldritch
Copy link

@LucoEldritch LucoEldritch commented Feb 1, 2022

Last example (Histogram) showed "min" instead of "max" in some places. Nevertheless, the value 0.5 seems to be right.

@LucoEldritch
Update max-aggregation.asciidoc - Fix Histogram
4fd2959 
Last example (Histogram) showed "min" instead of "max" in some places. Nevertheless, the value 0.5 seems to be right.
@cla-checker-service
Copy link

cla-checker-service bot commented Feb 1, 2022 •
edited
Loading

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added v7.16.4 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 1, 2022
@michaelbaamonde michaelbaamonde added the >docs General docs changes label Feb 1, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Feb 1, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 1, 2022

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig self-requested a review February 1, 2022 21:00
@jrodewig jrodewig self-assigned this Feb 1, 2022
@jrodewig
Copy link
Contributor

jrodewig commented Feb 1, 2022 •
edited
Loading

👋 Hi @LucoEldritch,

Thanks for fixing this. To merge this change, we require a signed CLA:

https://www.elastic.co/contributor-agreement

You'll need to sign the CLA using the same email address associated with your commit. You can find that email address here: https://github.com/elastic/elasticsearch/commit/4fd2959158eaf8e938c3044d585820d38f971887.patch

Once you sign the CLA, I'll work on getting this merged.

Thanks again!

@jrodewig
Copy link
Contributor

jrodewig commented Feb 1, 2022

@elasticmachine test this please

jrodewig
jrodewig approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should update these snippets so the tests actually run, but I'll handle that as a separate effort.

@jrodewig jrodewig changed the title Update max-aggregation.asciidoc - Fix Histogram [DOCS] Fix copy/paste error in min aggregation docs Feb 1, 2022
@jrodewig jrodewig added the :Analytics/Aggregations Aggregations label Feb 1, 2022
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 1, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 1, 2022

Pinging @elastic/es-analytics-geo (Team:Analytics)

@jrodewig jrodewig changed the title [DOCS] Fix copy/paste error in min aggregation docs [DOCS] Fix copy/paste error in min agg docs Feb 1, 2022
@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@jrodewig jrodewig mentioned this pull request Feb 8, 2022
Merged
@jrodewig jrodewig removed >docs General docs changes :Analytics/Aggregations Aggregations v8.0.0 Team:Docs Meta label for docs team v7.10.3 v7.11.3 external-contributor Pull request authored by a developer outside the Elasticsearch team v7.12.2 v7.13.5 v7.14.3 v7.15.3 v7.16.4 v7.17.1 v8.2.0 labels Feb 8, 2022
@jrodewig
Copy link
Contributor

jrodewig commented Feb 8, 2022

I'm going to close out this issue due to lack of response. I've opened #83695 to update the snippets and fix some other issues.

Thanks again for raising this @LucoEldritch.

@jrodewig jrodewig closed this Feb 8, 2022
jrodewig added a commit that referenced this pull request Feb 9, 2022
@jrodewig
[DOCS] Fix min/max agg snippets for histograms (#83695)
280fd2f 
* Updates the `min` and `max` snippets for histograms. These should now run as docs integration tests.
* Fixes a copy/paste error in the `max` aggregation snippet for histograms.

Relates to #83384
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2022
@jrodewig
[DOCS] Fix min/max agg snippets for histograms (#83695) (#83700)
034de18 
* Updates the `min` and `max` snippets for histograms. These should now run as docs integration tests.
* Fixes a copy/paste error in the `max` aggregation snippet for histograms.

Relates to #83384

(cherry picked from commit 280fd2f)
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2022
@jrodewig
[DOCS] Fix min/max agg snippets for histograms (#83695) (#83698)
02e798d 
* Updates the `min` and `max` snippets for histograms. These should now run as docs integration tests.
* Fixes a copy/paste error in the `max` aggregation snippet for histograms.

Relates to #83384

(cherry picked from commit 280fd2f)
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2022
@jrodewig
[DOCS] Fix min/max agg snippets for histograms (#83695) (#83701)
366e22d 
* Updates the `min` and `max` snippets for histograms. These should now run as docs integration tests.
* Fixes a copy/paste error in the `max` aggregation snippet for histograms.

Relates to #83384

(cherry picked from commit 280fd2f)
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2022
@jrodewig
[DOCS] Fix min/max agg snippets for histograms (#83695) (#83699)
52603b8 
* Updates the `min` and `max` snippets for histograms. These should now run as docs integration tests.
* Fixes a copy/paste error in the `max` aggregation snippet for histograms.

Relates to #83384

(cherry picked from commit 280fd2f)
@LucoEldritch
Copy link
Author

LucoEldritch commented Feb 13, 2022 •
edited
Loading

Sorry, I signed it, but my Github is configured to hide my e-mail and I didn't notice (didn't even know this existed, actually). So, the e-mail from the pull request isn't even real. Anyway, thanks for the patience and attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jrodewig jrodewig

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LucoEldritch @elasticmachine @jrodewig @mark-vieira @michaelbaamonde @elasticsearchmachine