Correct context for CancellableSOCache listener (#83021) #83169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
backport
auto-merge-without-approval
Today the `CancellableSingleObjectCache` completes its listeners in the thread context of the `get()` call that actually computes the value which will be the correct context only if no batching took place. With this commit we make sure to complete each listener in the context in which it was passed to the corresponding `get()` call.
DaveCTurner
force-pushed
the
2022-01-26-backport-83021-7.17
branch
from
3d22277 to
a66be37
Compare
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
CancellableSingleObjectCachecompletes its listeners in thethread context of the
get()call that actually computes the valuewhich will be the correct context only if no batching took place. With
this commit we make sure to complete each listener in the context in
which it was passed to the corresponding
get()call.