[7.17] Prevent 6.8 indices upgrade to 8.0 (#82689)#82771
Merged
grcevski merged 5 commits intoelastic:7.17from Jan 20, 2022
Merged
[7.17] Prevent 6.8 indices upgrade to 8.0 (#82689)#82771grcevski merged 5 commits intoelastic:7.17from
grcevski merged 5 commits intoelastic:7.17from
Conversation
added 2 commits
January 18, 2022 19:40
DaveCTurner
reviewed
Jan 19, 2022
| logger.trace("loaded metadata [{}] from [{}]", userData, reader.directory()); | ||
| assert userData.size() == COMMIT_DATA_SIZE : userData; | ||
| assert (userData.size() == COMMIT_DATA_SIZE) | ||
| || ((userData.size() == COMMIT_DATA_SIZE - 1) && (userData.containsKey(OLDEST_INDEX_VERSION_KEY) == false)) : userData; |
Contributor
There was a problem hiding this comment.
Ah ok ignore my comment on this subject in the 8.x version.
grcevski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #82689 with small change to only compute the latest index version, but not act on it.
The check to prevent ES start because of old indices is only applicable to versions 8.0+, since all 7 versions can still work with the older 6.8 index format.