Skip to content

Java 17 instanceof pattern matching leftovers #82768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Java 17 instanceof pattern matching leftovers #82768

merged 1 commit into from
Jan 20, 2022

Conversation

@astefan
Copy link
Contributor

@astefan astefan commented Jan 18, 2022

Pattern matching for instanceof. Wrapping up

@astefan astefan marked this pull request as ready for review January 18, 2022 23:17
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 18, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 18, 2022

Pinging @elastic/es-core-infra (Team:Core/Infra)

@astefan astefan requested a review from tvernum January 18, 2022 23:18
@astefan astefan mentioned this pull request Jan 18, 2022
Open
19 tasks
@astefan astefan requested review from jkakavas and removed request for tvernum January 19, 2022 12:21
arteam
arteam approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astefan astefan merged commit b3d15c5 into elastic:master Jan 20, 2022
@astefan astefan deleted the java17/instanceof/cleanup branch January 20, 2022 08:12
astefan added a commit to astefan/elasticsearch that referenced this pull request Jan 20, 2022
@astefan
Pattern matching for instanceof. Wrapping up (elastic#82768)
b84a5e2
@astefan astefan mentioned this pull request Jan 20, 2022
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 20, 2022

💚 Backport successful

Status Branch Result
✅ 8.0

elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2022
@astefan
Pattern matching for instanceof. Wrapping up (#82768) (#82843)
43e5af8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkakavas jkakavas Awaiting requested review from jkakavas

1 more reviewer

@arteam arteam arteam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >non-issue >refactoring Team:Core/Infra Meta label for core/infra team v8.0.0-rc2 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@astefan @elasticmachine @elasticsearchmachine @arteam @pugnascotia