Xcontent filter: Add map and builder filter benchmark#81575
Merged
nik9000 merged 4 commits intoelastic:masterfrom Dec 14, 2021
Merged
Xcontent filter: Add map and builder filter benchmark#81575nik9000 merged 4 commits intoelastic:masterfrom
nik9000 merged 4 commits intoelastic:masterfrom
Conversation
Member
|
This feels pretty similar to the benchmark I did in #77154. It feels more general than what I made though which is nice. I'd love to use the parser based filtering any place where we can! |
Member
|
@elasticsearch, test this please |
Contributor
Author
yeah, It's an additional to your PR |
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Member
|
issue label checking robot. please wake up |
nik9000
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add the map and builder in the
FilterContentBenchmark. The result show that parser performance is much better than map and builder. Later my colleague and I will commit some PR, that It will replace from map and builder to parser.In wildcard case, map filter is so slow:
and parse filter has a little improvement with builder filter:
Here is the full benchmark result: