Add codec support for Lucene 6 and 7 versions #81258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
commented
Dec 2, 2021
...rg/elasticsearch/xpack/searchablesnapshots/store/input/BaseSearchableSnapshotIndexInput.java
Show resolved
Hide resolved
jpountz
reviewed
Dec 3, 2021
| public SegmentInfoFormat segmentInfoFormat() { | ||
| return segmentInfosFormat; | ||
| } | ||
| private final PostingsFormat postingsFormat = new EmptyPostingsFormat(); |
There was a problem hiding this comment.
Let's fix Lucene to only pull the postings format if any of the fields has postings, like we already do for points and doc values?
There was a problem hiding this comment.
ywelsch
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
approved these changes
Dec 7, 2021
.../old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/OldLuceneVersions.java
Outdated
Show resolved
Hide resolved
.../old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/OldLuceneVersions.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/elasticsearch/xpack/lucene/bwc/codecs/lucene60/Lucene60FieldInfosFormat.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/lucene/bwc/codecs/lucene50/Lucene50LiveDocsFormat.java
Outdated
Show resolved
Hide resolved
dnhatn
reviewed
Dec 7, 2021
.../old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/OldLuceneVersions.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Lucene support for reading
_idand_sourcefrom ES 5 / ES 6 indices.The codec classes are copies from Lucene where only read path is kept.
Relates #81210