Add '$' syntax as a shortcut for 'field' in Painless #80518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
reviewed
Nov 23, 2021
...g-painless/src/main/java/org/elasticsearch/painless/phase/PainlessSemanticAnalysisPhase.java
Outdated
Show resolved
Hide resolved
stu-elastic
reviewed
Nov 29, 2021
modules/lang-painless/src/main/java/org/elasticsearch/painless/antlr/Walker.java
Show resolved
Hide resolved
stu-elastic
reviewed
Nov 29, 2021
...g-painless/src/main/java/org/elasticsearch/painless/phase/PainlessSemanticAnalysisPhase.java
Show resolved
Hide resolved
stu-elastic
reviewed
Nov 29, 2021
...g-painless/src/main/java/org/elasticsearch/painless/phase/PainlessUserTreeToIRTreePhase.java
Show resolved
Hide resolved
stu-elastic
approved these changes
Nov 30, 2021
Contributor
stu-elastic
left a comment
stu-elastic
left a comment
There was a problem hiding this comment.
lgtm with some tests and a comment on the way forward regarding the specialization of $ in the asm phase.
Contributor
Author
|
@stu-elastic Thanks for the review! Will add some more tests and roll from there. |
Contributor
Author
|
Added additional tests. Will commit as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a shortcut for the
fieldmethod when a script context supports the scripting fields API. This shortcut replacesfield('fieldname').get(defaultValue)with$('fieldname', defaultValue). This change builds this into the Painless compiler, but eventually this can be easily refactored out to make it so the '$' could be specialized per context.