Rename shared cache static constant settings #79999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
Member
Author
|
Thanks Artem! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 3, 2021
The FrozenCacheService contains various settings whose Java static constants have a different prefix: FROZEN_CACHE_*, SNAPSHOT_CACHE_* or SHARED_CACHE_*. This commit renames the constants so that they all start with SHARED_CACHE_ prefix.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 3, 2021
The FrozenCacheService contains various settings whose Java static constants have a different prefix: FROZEN_CACHE_*, SNAPSHOT_CACHE_* or SHARED_CACHE_*. This commit renames the constants so that they all start with SHARED_CACHE_ prefix.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 3, 2021
The FrozenCacheService contains various settings whose Java static constants have a different prefix: FROZEN_CACHE_*, SNAPSHOT_CACHE_* or SHARED_CACHE_*. This commit renames the constants so that they all start with SHARED_CACHE_ prefix.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 3, 2021
The FrozenCacheService contains various settings whose Java static constants have a different prefix: FROZEN_CACHE_*, SNAPSHOT_CACHE_* or SHARED_CACHE_*. This commit renames the constants so that they all start with SHARED_CACHE_ prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that the
FrozenCacheServicecontains various settings whose Java static constants have a different prefix:FROZEN_CACHE_*,SNAPSHOT_CACHE_*orSHARED_CACHE_*.This pull request renames the constants so that they all start with
SHARED_CACHE_which IMO better reflect the name of the component (and setting key).