-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Reduce deprecation logging severity for settings that are not removed in 8.0 #79665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce deprecation logging severity for settings that are not removed in 8.0 #79665
Conversation
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jbaiera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the monitoring changes, though I think just one got missed
| public static final Setting.AffixSetting<Boolean> USE_INGEST_PIPELINE_SETTING = | ||
| Setting.affixKeySetting("xpack.monitoring.exporters.","use_ingest", | ||
| key -> Setting.boolSetting(key, true, Property.Dynamic, Property.NodeScope, Property.Deprecated), TYPE_DEPENDENCY); | ||
| key -> Setting.boolSetting(key, true, Property.Dynamic, Property.NodeScope, Property.Deprecated), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should be at warning level as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That setting was removed in 8.x, so it should remain critical level .
tvernum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In a few months we should have a conversation about what the deprecation lifecycle looks like and how setting attributes should work with that. But not now.
|
@elasticmachine update branch |
Complementary to #79665 this change will reduce the deprecation logging level to WARN for (most) all non-settings that continue to exist in 8.0+.
This commit lowers the severity for all settings from critical to warning
for all settings that are still present in 8.0.0.
releated #79107
===
Note - I have requested review from @tvernum and @jbaiera since these settings are mostly from areas for which they are familiar. Please add others for review if needed.
cc: @masseyke @rjernst @pgomulka
===
Note this settings were identified by introducing the following debug code in 8.0.0 and 7.16 and comparing the two lists. If the same setting showed up as deprecated in both 7.16 and 8.0.0 it is included in this PR. If the setting was missing in 8.0.0, no changes since the default is critical.