Skip to content

Revert "Deprecate resolution loss on date field (#78921) backport(#79355)" #79613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2021
Merged

Revert "Deprecate resolution loss on date field (#78921) backport(#79355)" #79613

merged 2 commits into from
Oct 21, 2021

Conversation

@pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Oct 21, 2021 •
edited
Loading

This reverts commit ff6e589.
and
docs commit 69cf4a3.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka pgomulka added :Search Foundations/Mapping Index mappings, including merging and defining field types :Core/Infra/Core Core issues without another label v7.16.0 labels Oct 21, 2021
@pgomulka pgomulka self-assigned this Oct 21, 2021
@elasticmachine elasticmachine added Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team labels Oct 21, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 21, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 21, 2021

Pinging @elastic/es-search (Team:Search)

@pgomulka pgomulka requested a review from rjernst October 21, 2021 12:19
grcevski
grcevski approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The revert looks clean to me.

@pgomulka pgomulka merged commit ca1c03c into elastic:7.16 Oct 21, 2021
@pgomulka pgomulka mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst Awaiting requested review from rjernst

1 more reviewer

@grcevski grcevski grcevski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pgomulka @elasticmachine @grcevski @danhermann @elasticsearchmachine