Reduce BWC version for HotThreads.sort #79583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sort by change has been merged in 7.x now and therefore we should make 8.0 use the same BWC version. Relates to elastic#79392 and elastic#79507
grcevski
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Oct 20, 2021
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
This looks good, but are there no associated tests? I'm surprised CI has been passing with this out of sync.
Contributor
Author
|
I don't think there are any REST tests, let me see if we can add some. |
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
This reverts commit 2e92402.
- Add test as per Nhat's suggestions - Revert 8_0_0 to 7_16_0 so test passes.
…hub.com:grcevski/elasticsearch into enhancement/reduce_bwc_version_hot_threads_sort
grcevski
added a commit
to grcevski/elasticsearch
that referenced
this pull request
Oct 26, 2021
The sort by change has been merged in 7.x now and therefore we should make 8.0 use the same BWC version. Relates to elastic#79392 and elastic#79507 Co-authored-by: Nhat Nguyen <[email protected]>
grcevski
added a commit
that referenced
this pull request
Oct 27, 2021
Porting the tests and the updated rest spec to 7.16. Co-authored-by: Nhat Nguyen <[email protected]>
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
The sort by change has been merged in 7.x now and therefore we should make 8.0 use the same BWC version. Relates to elastic#79392 and elastic#79507 Co-authored-by: Nhat Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort by change has been merged in 7.x now and therefore
we should make 8.0 use the same BWC version.
Relates to #79392 and #79507