Skip to content

Conversation

@masseyke
Copy link
Member

A recent change for the deprecation logs provided the capability to emit deprecation's at critical vs. warning levels, #77482.
However deprecated settings always log at critical level without the ability to express that the setting deprecation is only a
warning.

This commit exposes the ability to set the deprecation level when deprecating a setting.
Closes #78781

…elastic#79107)

A recent change for the deprecation logs provided the capability to emit deprecation's at critical vs. warning levels, elastic#77482.
However deprecated settings always log at critical level without the ability to express that the setting deprecation is only a
warning.

This commit exposes the ability to set the deprecation level when deprecating a setting.
Closes elastic#78781
@masseyke masseyke added backport v7.16.0 :Core/Infra/Logging Log management and logging utilities labels Oct 19, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@masseyke
Copy link
Member Author

@elasticmachine update branch

@masseyke
Copy link
Member Author

@elasticmachine update branch

@masseyke masseyke merged commit 1f0e85b into elastic:7.x Oct 19, 2021
@masseyke masseyke deleted the feature/deprecated-settings-at-warning-level-7x branch October 19, 2021 19:32
masseyke added a commit that referenced this pull request Oct 19, 2021
As #79492 of the ESTestCase assertWarnings methods now check that the log level is of the expected type. This commit
puts in the correct expected log level.
Relates #79492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants