Add tests for fields emulation CCS error cases #78621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>test
|
Pinging @elastic/es-search (Team:Search) |
|
@cbuescher is this still valid or does it need to be closed? |
|
I think this is still relevant but not urgent to add. The tests added here should mainly assert the current behaviour, while I opened #78620 as a potential follow up if we decide to prevent this kind of errors by a retry. If you think adding these tests generally makes sense I will update the branch |
cbuescher
force-pushed
the
ccs-fields-error-tests
branch
from
05f10f5 to
6a633ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added an emulation layer to the "fields" option in #77749 that is able to translate search requests using the "fields" option for pre-7.10 nodes, e.g. in a mixed cluster or CCS use case.
This PR adds tests to those two use cases that assert the current failure behaviour when some of the target indices in earlier version have "_source" disabled. In this case we currently fail the respective shard requests and deliver the error (an IAE) in the response alongside the succesful hits.
Relates to #78620