Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 23, 2021

In our effort to get comprehensive rest tests for aggs (#26220) I've
added a few more tests for the parent and child aggs. The aggs
themselves don't have a ton of configuration, but I added a few examples
of running them inside of other aggs.

In our effort to get comprehensive rest tests for aggs (elastic#26220) I've
added a few more tests for the `parent` and `child` aggs. The aggs
themselves don't have a ton of configuration, but I added a few examples
of running them inside of other aggs.
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.0.0 v7.16.0 labels Sep 23, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit 7e7cfe3 into elastic:master Oct 4, 2021
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Oct 4, 2021
In our effort to get comprehensive rest tests for aggs (elastic#26220) I've
added a few more tests for the `parent` and `child` aggs. The aggs
themselves don't have a ton of configuration, but I added a few examples
of running them inside of other aggs.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine pushed a commit that referenced this pull request Oct 4, 2021
In our effort to get comprehensive rest tests for aggs (#26220) I've
added a few more tests for the `parent` and `child` aggs. The aggs
themselves don't have a ton of configuration, but I added a few examples
of running them inside of other aggs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants