Simplify test artifact compile classpath #78238
Conversation
breskeby
added
:Delivery/Build
- This fixes having transitive compile only dependencies on the classpath for consumers of test artifacts
breskeby
force-pushed
the
cleanup-test-artifact-compileclasspath
branch
from
f99fe3b to
ff977d0
Compare
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Does this mean we now don't get any transitive dependencies from test artifacts?
|
@mark-vieira basically all elasticsearch transitive modules and their api dependencies end up on the classpath now instead of the whole compile classpath that has leaked compileOnly and implementation configurations too. here's an example: |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
LGTM, although I think we might want to make some test dependencies api intead of implementation to reduce the need for consumers to have to declare those transitive dependencies that are obviously needed at compile time.
| dependencies { | ||
| testImplementation project(xpackModule('core')) | ||
| testImplementation(testArtifact(project(xpackModule('core')))) | ||
| testImplementation project(':test:framework') |
There was a problem hiding this comment.
I'm wondering if instances like this should really be testApi since the intent is that folks that consume this test artifact will also obviously need the test framework to compile against this.
There was a problem hiding this comment.
yeah this makes kind of sense. I'd like to revisit the api of our testFixtures in a separate commit.
There was a problem hiding this comment.
FWIW, @dakrone already hit this issue, where he pulled in this change and then had too add a bunch of transitive dependencies to get things working again.
|
This fixes having transitive compile only dependencies on the classpath for consumers of test artifacts |
- This fixes having transitive compile only dependencies on the classpath for consumers of test artifacts - We remove compile dependencies from the testArtifact configuration dependencies here as this leaks implementation and compile only deps to consuming projects
- This fixes having transitive compile only dependencies on the classpath for consumers of test artifacts - We remove compile dependencies from the testArtifact configuration dependencies here as this leaks implementation and compile only deps to consuming projects
5 participants
Uh oh!
There was an error while loading. Please reload this page.