Skip to content

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 15, 2021

Adds and integration test for the diversified_sampler aggregator.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.0.0 v7.16.0 labels Sep 15, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Adds and integration test for the `diversified_sampler` aggregator.
@not-napoleon
Copy link
Member

We should probably include the execution_hint parameter in the tests. Even if we just validate that the three options parse correctly, that at least gives us some BWC coverage.

@nik9000
Copy link
Member Author

nik9000 commented Sep 22, 2021

We should probably include the execution_hint parameter in the tests. Even if we just validate that the three options parse correctly, that at least gives us some BWC coverage.

Good call.

@nik9000
Copy link
Member Author

nik9000 commented Sep 22, 2021

Good call.

Done! @not-napoleon, could you have another look?

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit 3e5dbb0 into elastic:master Sep 22, 2021
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Sep 22, 2021
Adds and integration test for the `diversified_sampler` aggregator.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

nik9000 added a commit that referenced this pull request Sep 23, 2021
Adds and integration test for the `diversified_sampler` aggregator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants