Add sort optimization with after from Lucene #77615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucene 8.7 introduces numeric sort optimization directly in comparators. This means we don't need to have it in ES. This removes the sort optimization code in ES, and the only thing that is needed is setCanUsePoints on sortField. This also will introduce sort optimization with search_after, as Lucene directly supports sort optimization with search_after. As previously, we enable sort optimization only when there is Long sort on Long or Date fields. There could be a regression on desc sort, for example on @timestamp desc field. In this case, we suggest to convert these indices to data stream indices, as datatastream indices have their desc sort on @timestamp field optimized.
mayya-sharipova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene 8.7 introduces numeric sort optimization directly in comparators.
This means we don't need to have it in ES.
This removes the sort optimization code in ES, and
the only thing that is needed is setCanUsePoints on sortField.
This also will introduce sort optimization with search_after,
as Lucene directly supports sort optimization with search_after.
As previously, we enable sort optimization only when there is
Long sort on Long or Date fields.
There could be a regression on desc sort, for example on
@timestamp desc field. In this case, we suggest to
convert these indices to data stream indices, as
datatastream indices have their desc sort on
@timestamp field optimized
Backport for #64292